-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Master merge 1.14 #1444
Open
JoshVanL
wants to merge
13
commits into
dapr:master
Choose a base branch
from
JoshVanL:master-merge-1.14
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Master merge 1.14 #1444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Artur Souza <asouza.pro@gmail.com>
* fix: scheduler host address passed to runtime Signed-off-by: mikeee <hey@mike.ee> * fix: scheduler client stream initialised for 1.14< Signed-off-by: mikeee <hey@mike.ee> * fix: modify scheduler host address validation if the scheduler container is not active, the scheduler flag will not be passed to the runtime Signed-off-by: mikeee <hey@mike.ee> * fix: lint and refactor Signed-off-by: mikeee <hey@mike.ee> --------- Signed-off-by: mikeee <hey@mike.ee>
* dapr_scheduler: pre-create data dir Signed-off-by: joshvanl <me@joshvanl.dev> * Adds --scheduler-volume to specify volume for data directory Signed-off-by: joshvanl <me@joshvanl.dev> --------- Signed-off-by: joshvanl <me@joshvanl.dev>
Signed-off-by: yaron2 <schneider.yaron@live.com>
…apr#1423) * Give scheduler a default volume, making it resilient to restarts by default Signed-off-by: joshvanl <me@joshvanl.dev> * Remove dapr_scheduler volume on uninstall, gated by `--all` Signed-off-by: joshvanl <me@joshvanl.dev> * Fix containerErrs in standaone.go Signed-off-by: joshvanl <me@joshvanl.dev> * Do not attempt to delete scheduler volume if no container runtime Signed-off-by: joshvanl <me@joshvanl.dev> * Increase upgrade test timeout to 40m Signed-off-by: joshvanl <me@joshvanl.dev> --------- Signed-off-by: joshvanl <me@joshvanl.dev> Co-authored-by: Artur Souza <artursouza.ms@outlook.com>
* Add E2E to validate scheduler after init. Signed-off-by: Artur Souza <asouza.pro@gmail.com> * Adds dapr_scheduler verify container Signed-off-by: joshvanl <me@joshvanl.dev> * Assert eventually TCP connect Signed-off-by: joshvanl <me@joshvanl.dev> * Fix eventually t check Signed-off-by: joshvanl <me@joshvanl.dev> * Write etcd-data-dir to custom path with volume Signed-off-by: joshvanl <me@joshvanl.dev> * Adds Helpers to test funcs Signed-off-by: joshvanl <me@joshvanl.dev> * Adds container name to TCP check Signed-off-by: joshvanl <me@joshvanl.dev> * Use rc.3 for scheduler Signed-off-by: joshvanl <me@joshvanl.dev> * Print container logs on failed TCP conn Signed-off-by: joshvanl <me@joshvanl.dev> * Fix params Signed-off-by: joshvanl <me@joshvanl.dev> * Use b Signed-off-by: joshvanl <me@joshvanl.dev> * Addfs `dev` flag to rc init Signed-off-by: joshvanl <me@joshvanl.dev> * Fix version check Signed-off-by: joshvanl <me@joshvanl.dev> * Skip TCP check on slim mode Signed-off-by: joshvanl <me@joshvanl.dev> * Remove debug test code Signed-off-by: joshvanl <me@joshvanl.dev> --------- Signed-off-by: Artur Souza <asouza.pro@gmail.com> Signed-off-by: joshvanl <me@joshvanl.dev> Co-authored-by: Artur Souza <asouza.pro@gmail.com>
dapr#1429) Signed-off-by: joshvanl <me@joshvanl.dev>
* fix w/ @JoshVanL & anton Signed-off-by: Cassandra Coyle <cassie@diagrid.io> * add a . Signed-off-by: Cassandra Coyle <cassie@diagrid.io> --------- Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
Signed-off-by: Anton Troshin <anton@diagrid.io>
Signed-off-by: yaron2 <schneider.yaron@live.com>
Signed-off-by: yaron2 <schneider.yaron@live.com>
Signed-off-by: joshvanl <me@joshvanl.dev>
Signed-off-by: joshvanl <me@joshvanl.dev>
mikeee
previously approved these changes
Aug 30, 2024
Which PR is being run with - this one or #1442? |
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please explain the changes you've made
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #[issue number]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: